Skip to content

Conversation

@geoknee
Copy link
Contributor

@geoknee geoknee commented Oct 22, 2025

scope is now fixed.

depends on ethereum-optimism/op-geth#703

@geoknee geoknee requested review from a team as code owners October 22, 2025 11:04
@geoknee geoknee requested a review from sebastianst October 22, 2025 11:04
@geoknee geoknee added the H-jovian Hardfork: change is planned for jovian upgrade label Oct 22, 2025
@geoknee geoknee requested a review from a team as a code owner October 22, 2025 11:12
@geoknee geoknee requested a review from stevennevins October 22, 2025 11:12
@geoknee geoknee force-pushed the gk/toggle-off branch 2 times, most recently from ef83bd7 to 5aff201 Compare October 22, 2025 13:45
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.58%. Comparing base (70cfeb6) to head (dabdf9e).

❗ There is a different number of reports uploaded between BASE (70cfeb6) and HEAD (dabdf9e). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (70cfeb6) HEAD (dabdf9e)
contracts-bedrock-tests 6 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17978      +/-   ##
===========================================
- Coverage    76.27%   66.58%   -9.70%     
===========================================
  Files          179       55     -124     
  Lines        10732     4031    -6701     
===========================================
- Hits          8186     2684    -5502     
+ Misses        2402     1203    -1199     
  Partials       144      144              
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (ø)
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 124 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geoknee geoknee force-pushed the gk/toggle-off branch 2 times, most recently from 3204818 to 4954a4b Compare October 23, 2025 07:21
@geoknee geoknee added the M-do-not-merge Meta: Do not merge label Oct 24, 2025
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Nov 7, 2025
@opgitgovernance
Copy link
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@geoknee geoknee removed the S-stale Status: Will be closed unless there is activity label Nov 7, 2025
@geoknee geoknee removed the M-do-not-merge Meta: Do not merge label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

H-jovian Hardfork: change is planned for jovian upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants